Implement toString on File and Directory objects.

Implement toString on File and Directory objects.

R=sgjesse@google.com
BUG=dartbug.com/7552

Committed: https://code.google.com/p/dart/source/detail?r=16436

[Søren Gjesse, 2012-12-21 10:16:00]

lgtm

https://codereview.chromium.org/11661003/diff/1/sdk/lib/io/directory_impl.dart
File sdk/lib/io/directory_impl.dart (right):

https://codereview.chromium.org/11661003/diff/1/sdk/lib/io/directory_impl.dar...
sdk/lib/io/directory_impl.dart:231: String toString() => "Directory: '$path'";
Are you sure you want the "Directory: " prefix?

https://codereview.chromium.org/11661003/diff/1/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/11661003/diff/1/sdk/lib/io/file_impl.dart#new...
sdk/lib/io/file_impl.dart:707: String toString() => "File: '$name'";
Ditto.

[Søren Gjesse, 2012-12-21 10:16:53]

lgtm

Additional comment maybe drop path and name getters and only have toString.

[Mads Ager (google), 2012-12-21 10:35:03]

https://codereview.chromium.org/11661003/diff/1/sdk/lib/io/directory_impl.dart
File sdk/lib/io/directory_impl.dart (right):

https://codereview.chromium.org/11661003/diff/1/sdk/lib/io/directory_impl.dar...
sdk/lib/io/directory_impl.dart:231: String toString() => "Directory: '$path'";
On 2012/12/21 10:16:00, Søren Gjesse wrote:
> Are you sure you want the "Directory: " prefix?

Good question. I was thinking that it might be helpful for debugging purposes to
be able to print some entity and it will tell you what it is and the path.

[Mads Ager (google), 2012-12-21 11:00:22]

On 2012/12/21 10:35:03, Mads Ager wrote:
> https://codereview.chromium.org/11661003/diff/1/sdk/lib/io/directory_impl.dart
> File sdk/lib/io/directory_impl.dart (right):
> 
>
https://codereview.chromium.org/11661003/diff/1/sdk/lib/io/directory_impl.dar...
> sdk/lib/io/directory_impl.dart:231: String toString() => "Directory: '$path'";
> On 2012/12/21 10:16:00, Søren Gjesse wrote:
> > Are you sure you want the "Directory: " prefix?
> 
> Good question. I was thinking that it might be helpful for debugging purposes
to
> be able to print some entity and it will tell you what it is and the path.

I'll go ahead and land this for now. We should revisit this when we have a fresh
look at the File and Directory APIs after new years.