Issue 1166093002: Switch over testing pub seperately from the the normal packages

Issue 1166093002: Switch over testing pub seperately from the the normal packages (Closed)

Created:
5 years, 6 months ago by ricow1

Modified:
5 years, 6 months ago

Reviewers:
nweiz, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Switch over testing pub seperately from the the normal packages This will call a new test script that Natalie will fill in the blanks of for pub testing. This also moves pub from third_party/pkg_tested into third_party/pkg. The corresponding changes to the buildbot is here: http://src.chromium.org/viewvc/chrome?revision=295555&view=revision R=nweiz@google.com, whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f3c6339206aec69fa66b3724a5a4dd525ae78a8c

Patch Set 2 : windows bat file #

Total comments: 4

Patch Set 3 : Address comments and roll pub forward #

Patch Set 4 : also roll pub in dartium deps #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -73 lines)			Patch
M	DEPS	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	client/tools/buildbot_annotated_steps.py	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/bin/pub	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/bin/pub.bat	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/bots/pkg.py	View	1 2	4 chunks	+18 lines, -17 lines	0 comments	Download
M	tools/bots/pub.py	View	1 2	1 chunk	+39 lines, -46 lines	1 comment	Download
M	tools/create_sdk.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/deps/dartium.deps/DEPS	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/run_pub.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/pub.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

this depends on this landing and being rolled in: https://codereview.chromium.org/1164203003

5 years, 6 months ago (2015-06-08 16:48:44 UTC) #2

nweiz

lgtm https://codereview.chromium.org/1166093002/diff/20001/tools/bots/pkg.py File tools/bots/pkg.py (right): https://codereview.chromium.org/1166093002/diff/20001/tools/bots/pkg.py#newcode11 tools/bots/pkg.py:11: third_party/pkg_tested Nit: you lost a period here. https://codereview.chromium.org/1166093002/diff/20001/tools/bots/pub.py ...

5 years, 6 months ago (2015-06-08 20:45:02 UTC) #3

ricow1

https://codereview.chromium.org/1166093002/diff/20001/tools/bots/pkg.py File tools/bots/pkg.py (right): https://codereview.chromium.org/1166093002/diff/20001/tools/bots/pkg.py#newcode11 tools/bots/pkg.py:11: third_party/pkg_tested On 2015/06/08 20:45:01, nweiz wrote: > Nit: you ...

5 years, 6 months ago (2015-06-09 06:12:33 UTC) #4

ricow1

5 years, 6 months ago (2015-06-09 06:12:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
f3c6339206aec69fa66b3724a5a4dd525ae78a8c (presubmit successful).

Expand Messages | Collapse Messages