Issue 11660033: Remove unused variant of native JS class definition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11660033: Remove unused variant of native JS class definition. (Closed)

Created:
7 years, 12 months ago by sra1

Modified:
7 years, 11 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove unused variant of native JS class definition. Remove: class X native '=Foo' {} This was used for Console but now we use a Dart class with methods containing JS code. Committed: https://code.google.com/p/dart/source/detail?r=16507

Patch Set 1 #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -53 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart	View		3 chunks	+1 line, -31 lines	0 comments	Download
	D	tests/compiler/dart2js_native/native_literal_class_frog_test.dart	View		1 chunk	+0 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

7 years, 11 months ago (2013-01-02 07:50:36 UTC) #3

Message was sent while issue was closed.

LGTM!

Seems like a latent bug that we were using identical on a substring.

Cheers,
Peter

Expand Messages | Collapse Messages