Filling in supported platforms for InputElement types.

Filling in supported platforms for InputElement types.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=16529

[Emily Fortuna, 2012-12-27 22:39:45]

https://codereview.chromium.org/11659031/diff/1/tests/html/input_element_test...
File tests/html/input_element_test.dart (right):

https://codereview.chromium.org/11659031/diff/1/tests/html/input_element_test...
tests/html/input_element_test.dart:57: test('datetime', () {
can these tests be refactored so that there's less code duplication? Perhaps
write a helper method that does:
testHelper(var inputElement, String inputElemName) {
  var expectation = DateTimeInputElement.supported ? inputElemName : 'text';
  expect(inputElement is InputElement, true);
  expect(inputElement.type, expectation);
}

test('datetime', () {
  testHelper(new DateTimeInputElement(), 'datetime');
}

https://codereview.chromium.org/11659031/diff/1/tests/html/input_element_test...
tests/html/input_element_test.dart:71: test('date', () {
also, are you certain these tests that are not part of a named group are being
run? 

I seem to recall that the framework filters sets of tests by group names, so if
you use group names, all tests need to have a group name, otherwise they won't
be run. If you tested this, and it works fine, then ignore this comment; I just
recalled it working differently last time I tried this.

[blois, 2012-12-27 23:09:35]

https://codereview.chromium.org/11659031/diff/1/tests/html/input_element_test...
File tests/html/input_element_test.dart (right):

https://codereview.chromium.org/11659031/diff/1/tests/html/input_element_test...
tests/html/input_element_test.dart:57: test('datetime', () {
On 2012/12/27 22:39:45, Emily Fortuna wrote:
> can these tests be refactored so that there's less code duplication? Perhaps
> write a helper method that does:
> testHelper(var inputElement, String inputElemName) {
>   var expectation = DateTimeInputElement.supported ? inputElemName : 'text';
>   expect(inputElement is InputElement, true);
>   expect(inputElement.type, expectation);
> }
> 
> test('datetime', () {
>   testHelper(new DateTimeInputElement(), 'datetime');
> }

Good suggestion, done.

https://codereview.chromium.org/11659031/diff/1/tests/html/input_element_test...
tests/html/input_element_test.dart:71: test('date', () {
On 2012/12/27 22:39:45, Emily Fortuna wrote:
> also, are you certain these tests that are not part of a named group are being
> run? 
> 
> I seem to recall that the framework filters sets of tests by group names, so
if
> you use group names, all tests need to have a group name, otherwise they won't
> be run. If you tested this, and it works fine, then ignore this comment; I
just
> recalled it working differently last time I tried this.

You're correct- I found this out yesterday after I did this test. Fixed.

It works properly when run in the browser, just not via the test runner.

[Emily Fortuna, 2012-12-27 23:21:26]

lgtm

https://codereview.chromium.org/11659031/diff/4001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11659031/diff/4001/tests/html/html.status#new...
tests/html/html.status:77: indexeddb_1_test/supported: Fail         # IE10 does
not support from file://
You can open a bug about how the test framework should switch to serving files
from a server instead of the local filesystem. You can file it on me. I was
working on this last week before the break. (then add a TODO with the bug number
here)