Issue 1165733003: Let SyncStartIterable extend IterableBase instead of Iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1165733003: Let SyncStartIterable extend IterableBase instead of Iterable. (Closed)

Created:
5 years, 6 months ago by sigurdm

Modified:
5 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Let SyncStartIterable extend IterableBase instead of Iterable. Otherwise it misses implementations of all the helper methods. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/3322eeddeeb29d7ac9b0d021d078b0a722af25bd

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

sigurdm

5 years, 6 months ago (2015-06-19 07:24:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3322eeddeeb29d7ac9b0d021d078b0a722af25bd (presubmit successful).