Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1165283006: Build full LIBRARY_ELEMENT for every library source in the import/export closure, when resolve a un… (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Build full LIBRARY_ELEMENT for every library source in the import/export closure, when resolve a unit. This fixed 8 Analysis Server tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a2e4e671e99a9418a79caf5684d34e1840e120bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-09 20:41:51 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-09 21:01:59 UTC) #2
scheglov
5 years, 6 months ago (2015-06-09 21:02:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2e4e671e99a9418a79caf5684d34e1840e120bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698