Issue 1165263003: Follow getopt in parsing option-like values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1165263003: Follow getopt in parsing option-like values. (Closed)

Created:
5 years, 6 months ago by nweiz

Modified:
5 years, 6 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/args@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Follow getopt in parsing option-like values. The getopt function (and the GNU getopt_long extension) are the de facto standards for option parsing, so we should follow their behavior to make Dart programs consistent with other languages. Closes #36 R=rnystrom@google.com Committed: https://github.com/dart-lang/args/commit/7c611611bcc7a4fb07277d0aa0b802e24296776c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -13 lines)			Patch
M	CHANGELOG.md	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	lib/src/parser.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/parse_test.dart	View		2 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. Don't forget to tag and publish! https://codereview.chromium.org/1165263003/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1165263003/diff/1/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.13.1+1 ...

5 years, 6 months ago (2015-06-08 22:15:14 UTC) #2

nweiz

https://codereview.chromium.org/1165263003/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1165263003/diff/1/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.13.1+1 On 2015/06/08 22:15:14, Bob Nystrom wrote: > ...

5 years, 6 months ago (2015-06-08 23:06:10 UTC) #4

nweiz

5 years, 6 months ago (2015-06-08 23:06:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7c611611bcc7a4fb07277d0aa0b802e24296776c (presubmit successful).

Expand Messages | Collapse Messages