Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1165213002: Create a TypeDefiningElement interface. (Closed)

Created:
5 years, 6 months ago by Paul Berry
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org, Jennifer Messerly
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create a TypeDefiningElement interface. This interface is common to ClassElement, FunctionTypeAliasElement, and the element for the pseudo-type "dynamic". This should allow us to avoid some unnecessary casting in the dev_compiler (see https://codereview.chromium.org/1160223006/#msg11). R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/2c533ac971092f44db7416967cde2f1a1d2335d2

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 7 chunks +16 lines, -3 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
5 years, 6 months ago (2015-06-08 18:18:21 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1165213002/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/1165213002/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode271 pkg/analyzer/lib/src/generated/element.dart:271: @override We generally remove the comments for overriding ...
5 years, 6 months ago (2015-06-08 18:22:24 UTC) #3
Paul Berry
https://codereview.chromium.org/1165213002/diff/1/pkg/analyzer/lib/src/generated/element.dart File pkg/analyzer/lib/src/generated/element.dart (right): https://codereview.chromium.org/1165213002/diff/1/pkg/analyzer/lib/src/generated/element.dart#newcode271 pkg/analyzer/lib/src/generated/element.dart:271: @override On 2015/06/08 18:22:24, Brian Wilkerson wrote: > We ...
5 years, 6 months ago (2015-06-08 18:26:25 UTC) #4
Paul Berry
Committed patchset #1 (id:1) manually as 2c533ac971092f44db7416967cde2f1a1d2335d2 (presubmit successful).
5 years, 6 months ago (2015-06-08 18:29:07 UTC) #5
Jennifer Messerly
5 years, 6 months ago (2015-06-08 19:20:35 UTC) #7
Message was sent while issue was closed.
Thank you! LGTM

Powered by Google App Engine
This is Rietveld 408576698