Add Dart API method Dart_SetPersistentHandle to enable setting the value of

Add Dart API method Dart_SetPersistentHandle to enable setting the value of
a persistent handle.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31443

[Ivan Posva, 2014-01-03 18:21:21]

LGTM with comments addressed.

-Ivan

https://codereview.chromium.org/116473004/diff/50001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/116473004/diff/50001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:588: if (!state->IsValidPersistentHandle(obj1)) {
In other places we just assert on this instead of raising an API error. This
call should not be special, so we should make it consistent, by either changing
this to an ASSERT or throwing API errors in the other places such as
Dart_HandleFromPersistent for example.

https://codereview.chromium.org/116473004/diff/50001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:596: return Api::Success();
Then you can also change the signature of the function to be void. As you will
never have an error returned.

[siva, 2014-01-03 18:33:48]

https://codereview.chromium.org/116473004/diff/50001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/116473004/diff/50001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:588: if (!state->IsValidPersistentHandle(obj1)) {
On 2014/01/03 18:21:21, Ivan Posva wrote:
> In other places we just assert on this instead of raising an API error. This
> call should not be special, so we should make it consistent, by either
changing
> this to an ASSERT or throwing API errors in the other places such as
> Dart_HandleFromPersistent for example.

Done.

https://codereview.chromium.org/116473004/diff/50001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:596: return Api::Success();
On 2014/01/03 18:21:21, Ivan Posva wrote:
> Then you can also change the signature of the function to be void. As you will
> never have an error returned.

Done.

[siva, 2014-01-03 18:47:41]

Committed patchset #3 manually as r31443 (presubmit successful).