Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 11647044: Adding annotation for partial browser support and example implementation for MutationObservers. (Closed)

Created:
8 years ago by blois
Modified:
8 years ago
Reviewers:
Emily Fortuna, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding annotation for partial browser support and example implementation for MutationObservers. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16449

Patch Set 1 #

Patch Set 2 : Added experimental annotation to MutationObserver. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -68 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 5 chunks +14 lines, -13 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 5 chunks +13 lines, -14 lines 0 comments Download
M sdk/lib/html/html_common/html_common.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/html_common/html_common_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
A sdk/lib/html/html_common/metadata.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M sdk/lib/html/src/Measurement.dart View 2 chunks +1 line, -2 lines 0 comments Download
D sdk/lib/html/src/dart2js_MutationObserverSupported.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D sdk/lib/html/src/dartium_MutationObserverSupported.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/html/templates/html/dartium/html_dartium.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/html/templates/html/impl/impl_MutationObserver.darttemplate View 1 1 chunk +17 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/html/mutationobserver_test.dart View 8 chunks +33 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
8 years ago (2012-12-21 01:46:45 UTC) #1
sra1
lgtm
8 years ago (2012-12-21 02:49:21 UTC) #2
Emily Fortuna
lgtm. Any reason why Experimental annotation can take arguments?
8 years ago (2012-12-21 18:57:38 UTC) #3
blois
8 years ago (2012-12-21 19:00:58 UTC) #4
On 2012/12/21 18:57:38, Emily Fortuna wrote:
> lgtm. Any reason why Experimental annotation can take arguments?

Could have used:
  const experimental = const Experimental();
then:
  @experimental
  class MutationObserver

But it's odd to have two syntaxes for annotations. The preferences voiced for
@deprecated and @override was to move both to @Override() so they would have
consistent syntax.

Powered by Google App Engine
This is Rietveld 408576698