Issue 11647038: Reapply "Optimize the message queue for many active ports with few messages."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11647038: Reapply "Optimize the message queue for many active ports with few messages." (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Optimize the message queue for many active ports with few messages." BUG= Committed: https://code.google.com/p/dart/source/detail?r=16394

Patch Set 1 #

Patch Set 2 : Fix stupidity in test. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -166 lines)			Patch
M	runtime/lib/isolate_patch.dart	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_entry.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/vm/dart_entry.cc	View		2 chunks	+34 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.cc	View		2 chunks	+16 lines, -1 line	0 comments	Download
M	runtime/vm/message.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/message.cc	View		2 chunks	+2 lines, -27 lines	0 comments	Download
M	runtime/vm/message_handler.cc	View		4 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/vm/message_handler_test.cc	View	1	8 chunks	+87 lines, -48 lines	0 comments	Download
M	runtime/vm/message_test.cc	View		2 chunks	+2 lines, -76 lines	0 comments	Download
M	runtime/vm/object_store.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/object_store.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

8 years ago (2012-12-20 20:01:05 UTC) #1

Reapply change after fixing some stupidity I introduced in a test. Growing the
buffer of ports was wrongly implemented and I did not fetch the new buffer after
filling more stuff in it.

Expand Messages | Collapse Messages