Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 11647003: Move path ("pathos") to pkg/. (Closed)

Created:
8 years ago by Bob Nystrom
Modified:
8 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, dgrove, Mads Ager (google)
Visibility:
Public.

Description

Move path ("pathos") to pkg/. Committed: https://code.google.com/p/dart/source/detail?r=16297

Patch Set 1 #

Patch Set 2 : Exclude "path" from apidoc. #

Total comments: 3

Patch Set 3 : Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1479 lines) Patch
A + pkg/path/lib/path.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/path/pubspec.yaml View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A + pkg/path/test/path_posix_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + pkg/path/test/path_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + pkg/path/test/path_windows_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/apidoc.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M utils/pub/command_lish.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/command_uploader.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/directory_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/io.dart View 1 chunk +1 line, -1 line 0 comments Download
D utils/pub/path.dart View 1 chunk +0 lines, -651 lines 0 comments Download
M utils/pub/pub.dart View 2 chunks +1 line, -1 line 0 comments Download
M utils/pub/validator/name.dart View 1 chunk +1 line, -1 line 0 comments Download
D utils/tests/pub/path/path_posix_test.dart View 1 chunk +0 lines, -361 lines 0 comments Download
D utils/tests/pub/path/path_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D utils/tests/pub/path/path_windows_test.dart View 1 chunk +0 lines, -395 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
This is in preparation for putting it on pub.dartlang.org so that web_ui and buildtool can ...
8 years ago (2012-12-18 21:25:26 UTC) #1
nweiz
lgtm https://codereview.chromium.org/11647003/diff/2001/pkg/path/pubspec.yaml File pkg/path/pubspec.yaml (right): https://codereview.chromium.org/11647003/diff/2001/pkg/path/pubspec.yaml#newcode10 pkg/path/pubspec.yaml:10: configurations-specific code is supported by Dart. Nit: "configuration" ...
8 years ago (2012-12-18 22:56:57 UTC) #2
Bob Nystrom
Thanks! https://codereview.chromium.org/11647003/diff/2001/pkg/path/pubspec.yaml File pkg/path/pubspec.yaml (right): https://codereview.chromium.org/11647003/diff/2001/pkg/path/pubspec.yaml#newcode10 pkg/path/pubspec.yaml:10: configurations-specific code is supported by Dart. On 2012/12/18 ...
8 years ago (2012-12-18 23:57:36 UTC) #3
nweiz
https://codereview.chromium.org/11647003/diff/2001/pkg/path/pubspec.yaml File pkg/path/pubspec.yaml (right): https://codereview.chromium.org/11647003/diff/2001/pkg/path/pubspec.yaml#newcode10 pkg/path/pubspec.yaml:10: configurations-specific code is supported by Dart. On 2012/12/18 23:57:36, ...
8 years ago (2012-12-19 00:48:46 UTC) #4
Bob Nystrom
8 years ago (2012-12-19 22:32:12 UTC) #5
Message was sent while issue was closed.
On 2012/12/19 00:48:46, nweiz wrote:
> https://codereview.chromium.org/11647003/diff/2001/pkg/path/pubspec.yaml
> File pkg/path/pubspec.yaml (right):
> 
>
https://codereview.chromium.org/11647003/diff/2001/pkg/path/pubspec.yaml#newc...
> pkg/path/pubspec.yaml:10: configurations-specific code is supported by Dart.
> On 2012/12/18 23:57:36, Bob Nystrom wrote:
> > On 2012/12/18 22:56:57, nweiz wrote:
> > > Nit: "configuration"
> > > 
> > > Also, wouldn't it be relatively easy to add a "builder" library that is
> > > importable in the browser?
> > 
> > Yeah, if we wanted path to not depend on dart io, that could be pulled out.
> But
> > that would mean you'd always have to do two imports to use it, which is
lame.
> 
> Not so; we have re-exporting.
>

True, but that still couples the importing code to a specific configuration.
 
> How do you envision it being used on the browser if not with a builder?
There's
> no context information like CWD or operating system.

I haven't put much thought into this yet, but I have a dream that I can make
URLs just another path style that this supports. On a browser, then, you could
use window.location.href as something like the cwd.

Powered by Google App Engine
This is Rietveld 408576698