Issue 1164563005: Add type arguments to lists in the code generator and make them fixed length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1164563005: Add type arguments to lists in the code generator and make them fixed length. (Closed)

Created:
5 years, 6 months ago by karlklose

Modified:
5 years, 6 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add type arguments to lists in the code generator and make them fixed length. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/e9656e8db148bd783e577fdbcfc8ec39b8d77c4f

Patch Set 2 : Fix long line. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -18 lines)			Patch
	M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1	12 chunks	+20 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/1164563005/diff/1/pkg/compiler/lib/src/js_backend/codegen/codegen.dart File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right): https://codereview.chromium.org/1164563005/diff/1/pkg/compiler/lib/src/js_backend/codegen/codegen.dart#newcode159 pkg/compiler/lib/src/js_backend/codegen/codegen.dart:159: List<js.Expression> visitExpressionList(List<tree_ir.Expression> expressions) { Long line.

5 years, 6 months ago (2015-06-03 09:45:40 UTC) #2

karlklose

5 years, 6 months ago (2015-06-03 11:49:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e9656e8db148bd783e577fdbcfc8ec39b8d77c4f (presubmit successful).

Expand Messages | Collapse Messages

Issue 1164563005: Add type arguments to lists in the code generator and make them fixed length. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix long line. #

Messages