Issue 11645041: Fix URI encoding/decoding of + and space

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11645041: Fix URI encoding/decoding of + and space (Closed)

Created:
8 years ago by Søren Gjesse

Modified:
8 years ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix URI encoding/decoding of + and space The URI decoder now encodes space as + and + as %2B. Likewise the URI decode decodes + as space (and %2B as +, but that was already the case). R=lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16419

Patch Set 1 #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -3 lines)			Patch
M	sdk/lib/uri/encode_decode.dart	View	3 chunks	+8 lines, -2 lines	2 comments	Download
M	tests/standalone/io/url_encoding_test.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/utils/uri_test.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/11645041/diff/1/sdk/lib/uri/encode_decode.dart File sdk/lib/uri/encode_decode.dart (right): https://codereview.chromium.org/11645041/diff/1/sdk/lib/uri/encode_decode.dart#newcode83 sdk/lib/uri/encode_decode.dart:83: if (canonical.indexOf(text[i]) >= 0) { Ick, that looks ...

8 years ago (2012-12-20 23:24:32 UTC) #2

Søren Gjesse

8 years ago (2012-12-21 08:51:19 UTC) #3

https://codereview.chromium.org/11645041/diff/1/sdk/lib/uri/encode_decode.dart
File sdk/lib/uri/encode_decode.dart (right):

https://codereview.chromium.org/11645041/diff/1/sdk/lib/uri/encode_decode.dar...
sdk/lib/uri/encode_decode.dart:83: if (canonical.indexOf(text[i]) >= 0) {
On 2012/12/20 23:24:32, Lasse Reichstein Nielsen wrote:
> Ick, that looks slow - indexOf is linear in the canonical string.

Created a new change to address this.

Expand Messages | Collapse Messages