Issue 11645019: Fixed Issue 7508: Many StringBuffer methods return StringBuffer, but should be void.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11645019: Fixed Issue 7508: Many StringBuffer methods return StringBuffer, but should be void. (Closed)

Created:
8 years ago by bakster

Modified:
8 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixed Issue 7508: Many StringBuffer methods return StringBuffer, but should be void. - Methods in StringBuffer have now been changed so they do not return this. - This forces the programmer to use cascaded calls instead of flaky chaining of calls. Committed: https://code.google.com/p/dart/source/detail?r=16358

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -97 lines)			Patch
M	pkg/intl/lib/bidi_utils.dart	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	runtime/lib/string_base.dart	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	sdk/lib/core/string_buffer.dart	View	2 chunks	+34 lines, -76 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/corelib/string_buffer_test.dart	View	4 chunks	+5 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages