Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 116443007: Fix how we compute _packageRoot in loader.dart. This is to fix a rare (Closed)

Created:
7 years ago by Siggi Cherem (dart-lang)
Modified:
7 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix how we compute _packageRoot in loader.dart. This is to fix a rare canonicalization bug (see https://code.google.com/p/dart/issues/detail?id=15694) R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=31232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/polymer/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/loader.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
7 years ago (2013-12-18 02:33:59 UTC) #1
Jennifer Messerly
lgtm
7 years ago (2013-12-18 05:11:31 UTC) #2
Siggi Cherem (dart-lang)
7 years ago (2013-12-18 17:19:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31232 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698