add dartdoc to third_party/pkg, run dartdoc to generate docs for sdk and upload to GCS

add dartdoc to third_party/pkg, run dartdoc to generate docs for sdk and upload to GCS

BUG=
R=ricow@google.com

Committed: https://github.com/dart-lang/sdk/commit/91b2281e084c35ac051e5595eea4daecc5285230

[keertip, 2015-06-09 18:06:34]

keertip@google.com changed reviewers:
+ ricow@google.com

[keertip, 2015-06-11 15:18:41]

Rico,

Could you take a look? Thanks!

[ricow1, 2015-06-11 15:51:50]

https://codereview.chromium.org/1164423008/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/1164423008/diff/40001/DEPS#newcode235
DEPS:235:
"https://chromium.googlesource.com/external/github.com/valotas/mustache4dart.git"
+ Var("mustache4dart_rev"),
long line

https://codereview.chromium.org/1164423008/diff/40001/DEPS#newcode256
DEPS:256:
"https://chromium.googlesource.com/external/github.com/google/quiver-dart.git" +
Var("quiver_tag"),
long line

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/bot_utils.py
File tools/bots/bot_utils.py (right):

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/bot_utils.py...
tools/bots/bot_utils.py:211: return '%s/gen-dartdocs/%s' % (self.bucket,
revision)
Why don't you want to put this under channels?, I really think you should, so
that you can easily distinguish what is build on master, dev and stable

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/bot_utils.py...
tools/bots/bot_utils.py:288: def upload(self, local_path, remote_path,
recursive=False, public=False, multithread=False):
long line

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py
File tools/bots/dart_sdk.py (right):

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:36: utils.GetBuildRoot(BUILD_OS, 'release', 'ia32'),
indentation

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:37: 'dart-sdk')
indentatione

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:40: 'third_party', 'pkg' , 'dartdoc' , 'bin' ,
'dartdoc.dart')
long line

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:45: subprocess.call([dart_exe, '--package-root=' +
packages_dir, dartdoc_dart, '--sdk-docs',
long line

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:45: subprocess.call([dart_exe, '--package-root=' +
packages_dir, dartdoc_dart, '--sdk-docs',
'--package-root=%s' % packages_dir
is the python way

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:46: '--output', dirname, '--dart-sdk', dart_sdk,
'--package-root', packages_dir],
long line

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:154: destination = (namer.apidocs_directory(revision) +
'/' +
I don't like the + between strings, but I am fine with leaving it

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:164: # (This can happen if a build was forced, or a
commit had no changes in the
lose the ()

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:247: 
stray edit?

[keertip, 2015-06-11 18:10:10]

https://codereview.chromium.org/1164423008/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/1164423008/diff/40001/DEPS#newcode235
DEPS:235:
"https://chromium.googlesource.com/external/github.com/valotas/mustache4dart.git"
+ Var("mustache4dart_rev"),
On 2015/06/11 15:51:49, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/1164423008/diff/40001/DEPS#newcode256
DEPS:256:
"https://chromium.googlesource.com/external/github.com/google/quiver-dart.git" +
Var("quiver_tag"),
On 2015/06/11 15:51:49, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/bot_utils.py
File tools/bots/bot_utils.py (right):

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/bot_utils.py...
tools/bots/bot_utils.py:211: return '%s/gen-dartdocs/%s' % (self.bucket,
revision)
On 2015/06/11 15:51:50, ricow1 wrote:
> Why don't you want to put this under channels?, I really think you should, so
> that you can easily distinguish what is build on master, dev and stable

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/bot_utils.py...
tools/bots/bot_utils.py:288: def upload(self, local_path, remote_path,
recursive=False, public=False, multithread=False):
On 2015/06/11 15:51:49, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py
File tools/bots/dart_sdk.py (right):

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:36: utils.GetBuildRoot(BUILD_OS, 'release', 'ia32'),
On 2015/06/11 15:51:50, ricow1 wrote:
> indentation

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:37: 'dart-sdk')
On 2015/06/11 15:51:50, ricow1 wrote:
> indentatione

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:40: 'third_party', 'pkg' , 'dartdoc' , 'bin' ,
'dartdoc.dart')
On 2015/06/11 15:51:50, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:45: subprocess.call([dart_exe, '--package-root=' +
packages_dir, dartdoc_dart, '--sdk-docs',
On 2015/06/11 15:51:50, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:45: subprocess.call([dart_exe, '--package-root=' +
packages_dir, dartdoc_dart, '--sdk-docs',
On 2015/06/11 15:51:50, ricow1 wrote:
> '--package-root=%s' % packages_dir
> is the python way

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:46: '--output', dirname, '--dart-sdk', dart_sdk,
'--package-root', packages_dir],
On 2015/06/11 15:51:50, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:154: destination = (namer.apidocs_directory(revision) +
'/' +
On 2015/06/11 15:51:50, ricow1 wrote:
> I don't like the + between strings, but I am fine with leaving it

Acknowledged.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:164: # (This can happen if a build was forced, or a
commit had no changes in the
On 2015/06/11 15:51:50, ricow1 wrote:
> lose the ()

Done.

https://codereview.chromium.org/1164423008/diff/40001/tools/bots/dart_sdk.py#...
tools/bots/dart_sdk.py:247: 
On 2015/06/11 15:51:50, ricow1 wrote:
> stray edit?

Done.

[keertip, 2015-06-12 17:21:04]

PTAL!

[ricow1, 2015-06-15 07:09:30]

lgtm with long lines fixed

https://codereview.chromium.org/1164423008/diff/60001/DEPS
File DEPS (right):

https://codereview.chromium.org/1164423008/diff/60001/DEPS#newcode235
DEPS:235:
"https://chromium.googlesource.com/external/github.com/valotas/mustache4dart.git"
long line

https://codereview.chromium.org/1164423008/diff/60001/DEPS#newcode257
DEPS:257:
"https://chromium.googlesource.com/external/github.com/google/quiver-dart.git"
long line

https://codereview.chromium.org/1164423008/diff/60001/tools/bots/bot_utils.py
File tools/bots/bot_utils.py (right):

https://codereview.chromium.org/1164423008/diff/60001/tools/bots/bot_utils.py...
tools/bots/bot_utils.py:211: return '%s/channels/%s/gen-dartdocs/%s' %
(self.bucket, self.channel, revision)
long line

https://codereview.chromium.org/1164423008/diff/60001/tools/bots/bot_utils.py...
tools/bots/bot_utils.py:289: public=False, multithread=False):
we normally indent this after (

[keertip, 2015-06-15 16:14:32]

https://codereview.chromium.org/1164423008/diff/60001/DEPS
File DEPS (right):

https://codereview.chromium.org/1164423008/diff/60001/DEPS#newcode235
DEPS:235:
"https://chromium.googlesource.com/external/github.com/valotas/mustache4dart.git"
On 2015/06/15 07:09:30, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/1164423008/diff/60001/DEPS#newcode257
DEPS:257:
"https://chromium.googlesource.com/external/github.com/google/quiver-dart.git"
On 2015/06/15 07:09:30, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/1164423008/diff/60001/tools/bots/bot_utils.py
File tools/bots/bot_utils.py (right):

https://codereview.chromium.org/1164423008/diff/60001/tools/bots/bot_utils.py...
tools/bots/bot_utils.py:211: return '%s/channels/%s/gen-dartdocs/%s' %
(self.bucket, self.channel, revision)
On 2015/06/15 07:09:30, ricow1 wrote:
> long line

Done.

https://codereview.chromium.org/1164423008/diff/60001/tools/bots/bot_utils.py...
tools/bots/bot_utils.py:289: public=False, multithread=False):
On 2015/06/15 07:09:30, ricow1 wrote:
> we normally indent this after (

Done.

[keertip, 2015-06-15 16:25:59]

Committed patchset #6 (id:100001) manually as
91b2281e084c35ac051e5595eea4daecc5285230 (presubmit successful).