Issue 11644103: Adding types to dart:html's dartium files where possible.

Issue 11644103: Adding types to dart:html's dartium files where possible. (Closed)

Created:
7 years, 12 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Anton Muhin, sra1

CC:
reviews_dartlang.org, Anton Muhin

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding types to dart:html's dartium files where possible. We were omitting parameter types more often than we should have been. BUG=7529 Committed: https://code.google.com/p/dart/source/detail?r=17098

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review feedback. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -80 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View		54 chunks	+54 lines, -54 lines	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1	11 chunks	+11 lines, -11 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1	1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://chromiumcodereview.appspot.com/11644103/diff/1/sdk/lib/html/scripts/systemnative.py File sdk/lib/html/scripts/systemnative.py (left): https://chromiumcodereview.appspot.com/11644103/diff/1/sdk/lib/html/scripts/systemnative.py#oldcode447 sdk/lib/html/scripts/systemnative.py:447: (lambda x: 'dynamic') if needs_dispatcher else self._DartType)) do we ...

7 years, 12 months ago (2012-12-28 10:21:02 UTC) #3

blois

https://codereview.chromium.org/11644103/diff/1/sdk/lib/html/scripts/systemnative.py File sdk/lib/html/scripts/systemnative.py (left): https://codereview.chromium.org/11644103/diff/1/sdk/lib/html/scripts/systemnative.py#oldcode447 sdk/lib/html/scripts/systemnative.py:447: (lambda x: 'dynamic') if needs_dispatcher else self._DartType)) On 2012/12/28 ...

7 years, 11 months ago (2013-01-14 22:32:52 UTC) #4

thanks and lgtm

Expand Messages | Collapse Messages