Fixing a bunch of dartc errors in dart:html tests.

Fixing a bunch of dartc errors in dart:html tests.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=16413

[Emily Fortuna, 2012-12-21 00:44:18]

static analysis! It's useful! :-)

https://codereview.chromium.org/11644061/diff/2001/tests/html/html.status
File tests/html/html.status (left):

https://codereview.chromium.org/11644061/diff/2001/tests/html/html.status#old...
tests/html/html.status:289: [ $compiler == dartc ]
wow. :-P

https://codereview.chromium.org/11644061/diff/2001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11644061/diff/2001/tests/html/html.status#new...
tests/html/html.status:287: [ $compiler == dartc ]
can we just get rid of this branch now?

https://codereview.chromium.org/11644061/diff/2001/tests/html/htmlelement_tes...
File tests/html/htmlelement_test.dart (left):

https://codereview.chromium.org/11644061/diff/2001/tests/html/htmlelement_tes...
tests/html/htmlelement_test.dart:64: div.dataAttributes.forEach(void f(String
key, String value) {
I thought this was supported? no longer?

[blois, 2012-12-21 01:05:42]

https://codereview.chromium.org/11644061/diff/2001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11644061/diff/2001/tests/html/html.status#new...
tests/html/html.status:287: [ $compiler == dartc ]
On 2012/12/21 00:44:18, Emily Fortuna wrote:
> can we just get rid of this branch now?

Done, but I assume that there'll be something back before too long.

https://codereview.chromium.org/11644061/diff/2001/tests/html/htmlelement_tes...
File tests/html/htmlelement_test.dart (left):

https://codereview.chromium.org/11644061/diff/2001/tests/html/htmlelement_tes...
tests/html/htmlelement_test.dart:64: div.dataAttributes.forEach(void f(String
key, String value) {
On 2012/12/21 00:44:18, Emily Fortuna wrote:
> I thought this was supported? no longer?

It's supported, just needed to remove the return value and function name.

[Emily Fortuna, 2012-12-21 01:07:31]

lgtm

https://codereview.chromium.org/11644061/diff/2001/tests/html/htmlelement_tes...
File tests/html/htmlelement_test.dart (left):

https://codereview.chromium.org/11644061/diff/2001/tests/html/htmlelement_tes...
tests/html/htmlelement_test.dart:64: div.dataAttributes.forEach(void f(String
key, String value) {
On 2012/12/21 01:05:42, blois wrote:
> On 2012/12/21 00:44:18, Emily Fortuna wrote:
> > I thought this was supported? no longer?
> 
> It's supported, just needed to remove the return value and function name.

Oh okay. I thought for some reason that the vm and dart2js supported actually 
having the return value and function name, just not dart2js.

[blois, 2012-12-21 01:13:16]

https://codereview.chromium.org/11644061/diff/2001/tests/html/htmlelement_tes...
File tests/html/htmlelement_test.dart (left):

https://codereview.chromium.org/11644061/diff/2001/tests/html/htmlelement_tes...
tests/html/htmlelement_test.dart:64: div.dataAttributes.forEach(void f(String
key, String value) {
On 2012/12/21 01:07:31, Emily Fortuna wrote:
> On 2012/12/21 01:05:42, blois wrote:
> > On 2012/12/21 00:44:18, Emily Fortuna wrote:
> > > I thought this was supported? no longer?
> > 
> > It's supported, just needed to remove the return value and function name.
> 
> Oh okay. I thought for some reason that the vm and dart2js supported actually 
> having the return value and function name, just not dart2js.

Dartc was saying it's deprecated, but I don't know other than that. 

Removing them allows it to pass, so seems like a good thing :)