Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 11644038: Fix latin1 character predefinition in the symbol table. The code (Closed)

Created:
8 years ago by siva
Modified:
8 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix latin1 character predefinition in the symbol table. The code was doing two calls to FindIndex for every character. Committed: https://code.google.com/p/dart/source/detail?r=16417

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M runtime/vm/symbols.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/symbols.cc View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
8 years ago (2012-12-20 01:50:30 UTC) #1
siva
8 years ago (2012-12-20 01:57:43 UTC) #2
Ivan Posva
8 years ago (2012-12-20 23:46:23 UTC) #3
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698