Issue 11644030: Rename specialTreatmentFor, improve handling of constants as constructor parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11644030: Rename specialTreatmentFor, improve handling of constants as constructor parameters. (Closed)

Created:
8 years ago by Alan Knight

Modified:
8 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org, dgrove, justinfagnani

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename specialTreatmentFor, improve handling of constants as constructor parameters. Committed: https://code.google.com/p/dart/source/detail?r=16448

Patch Set 2 : Removed obsolete TODO #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -38 lines)			Patch
M	pkg/serialization/lib/serialization.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/serialization/lib/src/basic_rule.dart	View	1	9 chunks	+102 lines, -32 lines	0 comments	Download
M	pkg/serialization/lib/src/mirrors_helpers.dart	View		2 chunks	+21 lines, -2 lines	0 comments	Download
M	pkg/serialization/test/serialization_test.dart	View		3 chunks	+17 lines, -2 lines	0 comments	Download
M	pkg/serialization/test/test_models.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/11644030/diff/1/pkg/serialization/lib/src/basic_rule.dart File pkg/serialization/lib/src/basic_rule.dart (right): https://codereview.chromium.org/11644030/diff/1/pkg/serialization/lib/src/basic_rule.dart#newcode226 pkg/serialization/lib/src/basic_rule.dart:226: // TODO (alanknight): The "is String" mechanism here ...

8 years ago (2012-12-19 23:14:08 UTC) #2

Alan Knight

8 years ago (2012-12-21 18:30:01 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11644030/diff/1/pkg/serialization/lib/src/bas...
File pkg/serialization/lib/src/basic_rule.dart (right):

https://codereview.chromium.org/11644030/diff/1/pkg/serialization/lib/src/bas...
pkg/serialization/lib/src/basic_rule.dart:226: // TODO (alanknight): The "is
String" mechanism here should be more tightly
On 2012/12/19 23:14:08, John Messerly wrote:
> move/remove this todo?

Done.

Expand Messages | Collapse Messages

Issue 11644030: Rename specialTreatmentFor, improve handling of constants as constructor parameters. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Removed obsolete TODO #

Messages