Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1164223002: Fix several tests when the new task model is enabled (Closed)

Created:
5 years, 6 months ago by Brian Wilkerson
Modified:
5 years, 6 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -60 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 4 chunks +33 lines, -32 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 2 chunks +12 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 3 chunks +14 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 4 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 6 months ago (2015-06-07 19:29:27 UTC) #2
scheglov
LGTM
5 years, 6 months ago (2015-06-08 00:37:27 UTC) #3
Brian Wilkerson
5 years, 6 months ago (2015-06-08 02:31:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7230007d526205d371bebddf69ee0167edc7569d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698