Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 11642019: Implement debugger connection on Windows. (Closed)

Created:
8 years ago by Mads Ager (google)
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement debugger connection on Windows. This is a slightly cleaned up version of the code that Devon created. All of eventhandler and socket in bin is designed for async communication only. Therefore, it does not make much sense to use it for something as simple as this. I have put the sync send and receive operations into DebuggerConnectionImpl instead of attempting to use the async Socket::Read and Socket::Write. R=devoncarew@google.com,sgjesse@google.com,hausner@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16336

Patch Set 1 #

Patch Set 2 : Fix spacing #

Patch Set 3 : Enable debugger test on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -7 lines) Patch
M runtime/bin/dbg_connection.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M runtime/bin/dbg_connection_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/dbg_connection_android.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/dbg_connection_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/dbg_connection_linux.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/dbg_connection_macos.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/dbg_connection_macos.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/dbg_connection_win.h View 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/bin/dbg_connection_win.cc View 1 1 chunk +32 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
8 years ago (2012-12-19 13:11:58 UTC) #1
Mads Ager (google)
I verified this on Linux and Windows and it passes Matthias's test uploaded at: https://codereview.chromium.org/11576053/
8 years ago (2012-12-19 13:18:40 UTC) #2
hausner
Thank you. The simplifications LGTM. I uploaded the debugger wire api test, you can enable ...
8 years ago (2012-12-19 18:19:20 UTC) #3
Mads Ager (google)
8 years ago (2012-12-19 18:43:03 UTC) #4
Message was sent while issue was closed.
On 2012/12/19 18:19:20, hausner wrote:
> Thank you. The simplifications LGTM. I uploaded the debugger wire api test,
you
> can enable the test for Windows in standalone.status.

Excellent. Done!

Powered by Google App Engine
This is Rietveld 408576698