Issue 11642004: Revert "Cleaning up shadow dom tests."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11642004: Revert "Cleaning up shadow dom tests." (Closed)

Created:
8 years ago by blois

Modified:
8 years ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Cleaning up shadow dom tests." This reverts commit 16291 which had a compilation error (!). TBR=efortuna BUG= Committed: https://code.google.com/p/dart/source/detail?r=16292

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -35 lines)			Patch
M	tests/html/html.status	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	tests/html/shadow_dom_layout_test.dart	View	1 chunk	+4 lines, -9 lines	1 comment	Download
M	tests/html/shadow_dom_test.dart	View	3 chunks	+5 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

8 years ago (2012-12-18 22:12:50 UTC) #2

Message was sent while issue was closed.

I think I found your compilation error
(see below)
lgtm

https://codereview.chromium.org/11642004/diff/2001/tests/html/shadow_dom_layo...
File tests/html/shadow_dom_layout_test.dart (left):

https://codereview.chromium.org/11642004/diff/2001/tests/html/shadow_dom_layo...
tests/html/shadow_dom_layout_test.dart:28: catch () {
missed a closing } here

Expand Messages | Collapse Messages