Issue 11639017: Be explicit about use of W version on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11639017: Be explicit about use of W version on Windows. (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
ricow1, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Be explicit about use of W version on Windows. The trunk builder is unhappy. I don't understand why since we are defining UNICODE and _UNICODE in our header files. However, let's just be explicit. R=sgjesse@google.com,ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16322

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/bin/process_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Mads Ager (google)

Ah, the change to define UNICODE is not on trunk. I'll land this and merge ...

8 years ago (2012-12-19 14:36:59 UTC) #2

Message was sent while issue was closed.

lgtm