Issue 1163833002: Dart2js async-await. Bind the async-body to the current zone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1163833002: Dart2js async-await. Bind the async-body to the current zone. (Closed)

Created:
5 years, 6 months ago by sigurdm

Modified:
5 years, 4 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Dart2js async-await. Bind the async-body to the current zone. Also ensure the wrapping of js-functions happens only once per async-call. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/7e64f3d962e6109755b10f733d2949b6d71e9a94

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -45 lines)			Patch
M	pkg/compiler/lib/src/js/rewrite_async.dart	View	9 chunks	+14 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View	10 chunks	+27 lines, -39 lines	0 comments	Download

Total messages: 6 (1 generated)

floitsch

LGTM, but wait until everyone (including the VM) is on board.

5 years, 6 months ago (2015-06-01 13:38:08 UTC) #3

floitsch

I will commit this now for you. (Since I needed to do some merging).

5 years, 4 months ago (2015-08-17 13:56:30 UTC) #5

floitsch

5 years, 4 months ago (2015-08-17 13:56:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7e64f3d962e6109755b10f733d2949b6d71e9a94 (presubmit successful).