Issue 11638015: Fix 2 failing tests on windows.

Issue 11638015: Fix 2 failing tests on windows. (Closed)

Created:
8 years ago by devoncarew

Modified:
8 years ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix 2 failing tests on windows. Remove 4 failing (and obsolete) tests on windows. Enable proper reporting of junit test failures for windows. Committed: https://code.google.com/p/dart/source/detail?r=16333

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -535 lines)			Patch
M	compiler/java/com/google/dart/compiler/PackageLibraryManager.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	editor/build/build.py	View	1	3 chunks	+19 lines, -33 lines	0 comments	Download
M	editor/build/gsutil.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	editor/build/gsutilTest.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	editor/build/promote.py	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	editor/tools/features/com.google.dart.tools.tests.feature_releng/buildTests.xml	View	1	2 chunks	+7 lines, -21 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/META-INF/MANIFEST.MF	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java	View		4 chunks	+4 lines, -12 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/directoryset/DirectorySetEvent.java	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/directoryset/DirectorySetListener.java	View	1	1 chunk	+0 lines, -32 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/directoryset/DirectorySetManager.java	View	1	1 chunk	+0 lines, -195 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/TestAll.java	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
D	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/directoryset/DirectorySetManagerTest.java	View	1	1 chunk	+0 lines, -177 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/directoryset/TestAll.java	View	1	1 chunk	+0 lines, -25 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/PackageLibraryManagerProviderAnyTest.java	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danrubel

lgtm https://codereview.chromium.org/11638015/diff/1/editor/build/build.py File editor/build/build.py (right): https://codereview.chromium.org/11638015/diff/1/editor/build/build.py#newcode425 editor/build/build.py:425: # UploadTestHtml(buildout, to_bucket, revision, buildos, gsu) Should we ...

8 years ago (2012-12-19 14:55:32 UTC) #2

devoncarew

8 years ago (2012-12-19 17:35:13 UTC) #3

https://codereview.chromium.org/11638015/diff/1/editor/build/build.py
File editor/build/build.py (right):

https://codereview.chromium.org/11638015/diff/1/editor/build/build.py#newcode425
editor/build/build.py:425: #  UploadTestHtml(buildout, to_bucket, revision,
buildos, gsu)
On 2012/12/19 14:55:32, danrubel wrote:
> Should we continue to upload the test results as an HTML report?

I'd prefer no - it makes our build simpler to not do it. We get the same value
from the stdout output on the buildbots. Otherwise we have to have code to write
the html output, code to copy it up to GS, code in promote to delete the
directories...

https://codereview.chromium.org/11638015/diff/1/editor/tools/features/com.goo...
File
editor/tools/features/com.google.dart.tools.tests.feature_releng/buildTests.xml
(right):

https://codereview.chromium.org/11638015/diff/1/editor/tools/features/com.goo...
editor/tools/features/com.google.dart.tools.tests.feature_releng/buildTests.xml:176:
or test collector, because we want the HTML report to be generated
On 2012/12/19 14:55:32, danrubel wrote:
> Are we still generating an HTML report? Or should the comment be revised?

I did not change the failonerror flag. This comment was not correct even before
my changes (one use of failonerror was tru, one false). I'll clean these
comments up a bit -

https://codereview.chromium.org/11638015/diff/1/editor/tools/features/com.goo...
editor/tools/features/com.google.dart.tools.tests.feature_releng/buildTests.xml:221:
<target name="generateHtml">
On 2012/12/19 14:55:32, danrubel wrote:
> No longer called? Remove?

sgtm

Expand Messages | Collapse Messages