Issue 11637017: Change the HTTP Content-Length handling

Issue 11637017: Change the HTTP Content-Length handling (Closed)

Created:
8 years ago by Søren Gjesse

Modified:
8 years ago

Reviewers:
nweiz, Anders Johnsen

CC:
reviews_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change the HTTP Content-Length handling Move the handling of the Content-Length to the HttpHeaders object. This makes it possible to set the Content-Length through the headers as well as directly on HttpResponse and HttpClientRequest. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16357

Patch Set 1 #

Total comments: 4

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -36 lines)			Patch
M	pkg/http/test/http_test.dart	View	6 chunks	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/io/http_headers.dart	View	3 chunks	+22 lines, -1 line	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	14 chunks	+14 lines, -25 lines	2 comments	Download
M	sdk/lib/io/http_parser.dart	View	3 chunks	+7 lines, -8 lines	2 comments	Download
M	tests/standalone/io/http_content_length_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/11637017/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/11637017/diff/1/sdk/lib/io/http_impl.dart#newcode1338 sdk/lib/io/http_impl.dart:1338: //_content-Length = _httpConnection._httpParser.contentLength; Out-commented code. https://codereview.chromium.org/11637017/diff/1/sdk/lib/io/http_parser.dart File sdk/lib/io/http_parser.dart ...

8 years ago (2012-12-19 15:43:58 UTC) #3

Søren Gjesse

8 years ago (2012-12-20 07:39:01 UTC) #5

https://codereview.chromium.org/11637017/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11637017/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1338: //_content-Length =
_httpConnection._httpParser.contentLength;
On 2012/12/19 15:43:58, Anders Johnsen wrote:
> Out-commented code.

Done.

https://codereview.chromium.org/11637017/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/11637017/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:428: _contentLength = _headers.contentLength;
On 2012/12/19 15:43:58, Anders Johnsen wrote:
> Nice cleanup!

Thanks.

Expand Messages | Collapse Messages