Issue 11636033: Add regression tests for two issues (7525, 7513).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11636033: Add regression tests for two issues (7525, 7513). (Closed)

Created:
8 years ago by srdjan

Modified:
8 years ago

Reviewers:
Vyacheslav Egorov (Google), regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add regression tests for two issues (7525, 7513). Committed: https://code.google.com/p/dart/source/detail?r=16353

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
A	tests/language/issue7513_test.dart	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
A	tests/language/issue7525_test.dart	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with suggestions. https://codereview.chromium.org/11636033/diff/5/tests/language/issue7513_test.dart File tests/language/issue7513_test.dart (right): https://codereview.chromium.org/11636033/diff/5/tests/language/issue7513_test.dart#newcode15 tests/language/issue7513_test.dart:15: for (var i = 0; i ...

8 years ago (2012-12-20 00:55:57 UTC) #2

srdjan

8 years ago (2012-12-20 01:08:04 UTC) #3

https://codereview.chromium.org/11636033/diff/5/tests/language/issue7513_test...
File tests/language/issue7513_test.dart (right):

https://codereview.chromium.org/11636033/diff/5/tests/language/issue7513_test...
tests/language/issue7513_test.dart:15: for (var i = 0; i < 10000; i++) foo(a,
b);
On 2012/12/20 00:55:57, regis wrote:
> How about adding an Expect(...) to check the result of foo, either in the loop
> or after the loop?

Done.

https://codereview.chromium.org/11636033/diff/5/tests/language/issue7525_test...
File tests/language/issue7525_test.dart (right):

https://codereview.chromium.org/11636033/diff/5/tests/language/issue7525_test...
tests/language/issue7525_test.dart:15: foo();
On 2012/12/20 00:55:57, regis wrote:
> How about returning x from foo() and checking that it equals 2 here or outside
> the loop?

Done.

Expand Messages | Collapse Messages

Issue 11636033: Add regression tests for two issues (7525, 7513). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages