Issue 11636017: Cache resolution of two static functions frequently used in I/O.

Issue 11636017: Cache resolution of two static functions frequently used in I/O. (Closed)

Created:
8 years ago by Florian Schneider

Modified:
8 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cache resolution of two static functions frequently used in I/O. Committed: https://code.google.com/p/dart/source/detail?r=16360

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -42 lines)			Patch
runtime/lib/isolate.cc	View	1 2	1 chunk	+27 lines, -20 lines	0 comments	Download
runtime/vm/dart_entry.cc	View	1 2	1 chunk	+27 lines, -21 lines	0 comments	Download
runtime/vm/object_store.h	View		2 chunks	+16 lines, -0 lines	0 comments	Download
runtime/vm/object_store.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan https://codereview.chromium.org/11636017/diff/4001/runtime/lib/isolate.cc File runtime/lib/isolate.cc (right): https://codereview.chromium.org/11636017/diff/4001/runtime/lib/isolate.cc#newcode56 runtime/lib/isolate.cc:56: Function& func = Function::Handle(isolate); We ...

8 years ago (2012-12-19 19:11:31 UTC) #2

Florian Schneider

8 years ago (2012-12-20 12:42:25 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11636017/diff/4001/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://codereview.chromium.org/11636017/diff/4001/runtime/lib/isolate.cc#new...
runtime/lib/isolate.cc:56: Function& func = Function::Handle(isolate);
On 2012/12/19 19:11:31, Ivan Posva wrote:
> We tend to write this kind of code this way:
> 
> Function& func =
> Functions::Handle(isolate->object_store()->receive_potr_create_function());
> if (func.IsNull()) {
> ... <- The code from the else branch below.
> }

Done.

https://codereview.chromium.org/11636017/diff/4001/runtime/vm/dart_entry.cc
File runtime/vm/dart_entry.cc (right):

https://codereview.chromium.org/11636017/diff/4001/runtime/vm/dart_entry.cc#n...
runtime/vm/dart_entry.cc:325: Function& function = Function::Handle(isolate);
On 2012/12/19 19:11:31, Ivan Posva wrote:
> ditto

Done.

Expand Messages | Collapse Messages