Issue 11635017: Set kArrayCid as ResultCid for CreateArray instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11635017: Set kArrayCid as ResultCid for CreateArray instruction. (Closed)

Created:
8 years ago by Vyacheslav Egorov (Google)

Modified:
8 years ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Set kArrayCid as ResultCid for CreateArray instruction. Propagate the length of the array returned by CreateArray in constant propagation. Fold constant RelationalOp instructions. Together this allows to kill considerable amount of unrechable code emitted from array literal allocation. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16331

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -8 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		5 chunks	+43 lines, -7 lines	1 comment	Download
	M	runtime/vm/intermediate_language.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

8 years ago (2012-12-19 15:07:27 UTC) #2

LGTM.

https://codereview.chromium.org/11635017/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11635017/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:3804: const int result =
Integer::Cast(left).CompareWith(right);
Redundant Integer::Cast

Expand Messages | Collapse Messages