Issue 11630007: Remove deleted files from build files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11630007: Remove deleted files from build files (Closed)

Created:
8 years ago by Max Heinritz (Google)

Modified:
8 years ago

Reviewers:

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup CodeObservers (and update build file) - Move CodeObserver registration to the OS abstraction - Add DISALLOW and AllStatic to Code Observers where appropriate The builds for Mac and Windows broke when I submitted the earlier CL (11572032). This CL removes obselete files from the .gypi build file. BUG=7321 Committed: https://code.google.com/p/dart/source/detail?r=16284

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+299 lines, -224 lines)			Patch
M	runtime/vm/code_observers.h	View	4 chunks	+9 lines, -1 line	0 comments	Download
M	runtime/vm/code_observers.cc	View	2 chunks	+6 lines, -121 lines	0 comments	Download
D	runtime/vm/debuginfo_macos.cc	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	runtime/vm/debuginfo_win.cc	View	1 chunk	+0 lines, -50 lines	0 comments	Download
M	runtime/vm/os.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/os_android.cc	View	3 chunks	+132 lines, -0 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View	3 chunks	+137 lines, -0 lines	0 comments	Download
M	runtime/vm/os_macos.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/os_win.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download