Issue 23568. Fix for NPE in index when unresolved field formal parameter.

Issue 23568. Fix for NPE in index when unresolved field formal parameter.

R=brianwilkerson@google.com
BUG=https://code.google.com/p/dart/issues/detail?id=23568

Committed: https://github.com/dart-lang/sdk/commit/aad76fdcbfe86dbc9ab2694e2bcead387cd9d87e

[Brian Wilkerson, 2015-06-01 21:52:21]

LGTM

https://codereview.chromium.org/1162853004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/index_contributor.dart (right):

https://codereview.chromium.org/1162853004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/index_contributor.dart:445: Element
nameElement = new NameElement(node.name);
I understand why lines 484-485 need to change, but is the change on this line
necessary to fix the bug? I explicitly didn't change this code so that we didn't
have to create one new instance of IndexableElement every time we recorded a
relationship about the name.

[scheglov, 2015-06-01 22:07:25]

https://codereview.chromium.org/1162853004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/index/index_contributor.dart (right):

https://codereview.chromium.org/1162853004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/index/index_contributor.dart:445: Element
nameElement = new NameElement(node.name);
On 2015/06/01 21:52:20, Brian Wilkerson wrote:
> I understand why lines 484-485 need to change, but is the change on this line
> necessary to fix the bug? I explicitly didn't change this code so that we
didn't
> have to create one new instance of IndexableElement every time we recorded a
> relationship about the name.

We use "nameElement" only once, in different branches below, so we create only
one IndexableObject instance.

[scheglov, 2015-06-01 22:08:39]

Committed patchset #1 (id:1) manually as
aad76fdcbfe86dbc9ab2694e2bcead387cd9d87e (presubmit successful).