Issue 11628011: Inline ByteArrayBase.length in the flow graph optimizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11628011: Inline ByteArrayBase.length in the flow graph optimizer. (Closed)

Created:
8 years ago by Florian Schneider

Modified:
8 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline ByteArrayBase.length in the flow graph optimizer. Committed: https://code.google.com/p/dart/source/detail?r=16311

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -57 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	3 chunks	+53 lines, -49 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11628011/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/11628011/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1044 runtime/vm/flow_graph_optimizer.cc:1044: intptr_t OffsetForLengthGetter(MethodRecognizer::Kind kind) { static ? https://codereview.chromium.org/11628011/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1103 runtime/vm/flow_graph_optimizer.cc:1103: ...

8 years ago (2012-12-18 21:45:57 UTC) #2

Florian Schneider

8 years ago (2012-12-19 09:51:29 UTC) #3

https://codereview.chromium.org/11628011/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11628011/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1044: intptr_t
OffsetForLengthGetter(MethodRecognizer::Kind kind) {
On 2012/12/18 21:45:57, srdjan wrote:
> static ?

Done.

https://codereview.chromium.org/11628011/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1103: 
On 2012/12/18 21:45:57, srdjan wrote:
> I would remove empty lines between the case's.

Done.

Expand Messages | Collapse Messages

Issue 11628011: Inline ByteArrayBase.length in the flow graph optimizer. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages