Re-apply "support for typedef in checked mode" and fix the checked mode failures on drt by not shar…

Re-apply "support for typedef in checked mode" and fix the checked mode failures on drt by not sharing bound closures that have typedef checks.
Committed: https://code.google.com/p/dart/source/detail?r=16320

[ngeoffray, 2012-12-18 16:16:17]

Patch set 1 is the original change, that has already been reviewed. Patch set 2
contains the fix.

[floitsch, 2012-12-19 10:39:34]

LGTM.

https://codereview.chromium.org/11628009/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11628009/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1115: void
emitTypedefChecksOn(DartType type, void emitTest(Element element)) {
Rename to forEachTypedefCheckOf

Ideally this should become an iterable after the experimental merge:
Iterable typeChecksOf(DartType type) {
  return checkedTypedefs.where((TypedefElement typedef) {
    FunctionType typedefType =
        typedef.computeType(compiler).unalias(compiler);
    return compiler.types.isSubtype(type, typedefType);
  });
}

You could already do this now (using "filter") and just pay for the List
allocation for now.

[ngeoffray, 2012-12-19 13:32:27]

PTAL. I like the suggestion.

[floitsch, 2012-12-19 13:37:23]

STV.

https://codereview.chromium.org/11628009/diff/12001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11628009/diff/12001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1414: bool
hasTypedefChecks = typedefChecks.iterator().hasNext;
For your information: this will become:
!typedefChecks.isEmpty;

(which imho is even nicer).

[ngeoffray, 2012-12-19 13:47:27]

Thanks

https://codereview.chromium.org/11628009/diff/12001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/11628009/diff/12001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1414: bool
hasTypedefChecks = typedefChecks.iterator().hasNext;
On 2012/12/19 13:37:23, floitsch wrote:
> For your information: this will become:
> !typedefChecks.isEmpty;
> 
> (which imho is even nicer).

I was actually looking for it :-)