Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1162603009: A few more fixes for testing in the repo. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

A few more fixes for testing in the repo. These issues were hidden last time I was testing because I couldn't actually bring in pub via DEPS. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/6f2a1b90b8210a85a38aab1af479c047681c29e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M lib/src/barback/pub_package_provider.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M lib/src/io.dart View 1 chunk +7 lines, -1 line 0 comments Download
M test/test_pub.dart View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 6 months ago (2015-05-29 21:18:42 UTC) #1
Bob Nystrom
lgtm
5 years, 6 months ago (2015-05-29 21:22:10 UTC) #2
nweiz
5 years, 6 months ago (2015-05-29 21:22:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f2a1b90b8210a85a38aab1af479c047681c29e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698