Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1162513002: Actually use canonicalized parameter and return types. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Actually use canonicalized parameter and return types. 149.4kB -> 43.5kB (-70%) of Type, TypeArgument and TypeParameter in hello world R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/7c02eae5ec835c410682182bd380791f69b5eb8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/class_finalizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 6 months ago (2015-05-28 00:50:59 UTC) #2
regis
LGTM Good find!
5 years, 6 months ago (2015-05-28 01:03:16 UTC) #3
rmacnak
5 years, 6 months ago (2015-05-28 01:11:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7c02eae5ec835c410682182bd380791f69b5eb8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698