Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 1162423002: Build fixes. (Closed)

Created:
5 years, 6 months ago by pquitslund
Modified:
5 years, 6 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Build fixes. Long tail of fixes related to moving out of `pkg_tested`. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/2c5e890fc7b1bda0b576eab1c1ee499237308ee1

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M pkg/pkg.status View 2 chunks +3 lines, -0 lines 0 comments Download
M sdk/bin/dartanalyzer View 1 chunk +1 line, -1 line 0 comments Download
M sdk/bin/dartanalyzer.bat View 1 chunk +1 line, -1 line 0 comments Download
M third_party/pkg_tested/pkg_tested.status View 2 chunks +0 lines, -3 lines 0 comments Download
M utils/dartanalyzer/dartanalyzer.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
pquitslund
5 years, 6 months ago (2015-06-03 21:01:02 UTC) #2
Paul Berry
lgtm
5 years, 6 months ago (2015-06-03 21:02:07 UTC) #3
pquitslund
5 years, 6 months ago (2015-06-03 21:03:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2c5e890fc7b1bda0b576eab1c1ee499237308ee1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698