Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 11624031: Fix documentation bugs 7517 and 7518 in serialization. (Closed)

Created:
8 years ago by Alan Knight
Modified:
7 years, 11 months ago
Reviewers:
Kathy Walrath, sethladd
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix documentation bugs 7517 and 7518 in serialization. Committed: https://code.google.com/p/dart/source/detail?r=16581

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change in wording from Seth #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pkg/serialization/lib/serialization.dart View 1 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/serialization/lib/src/reader_writer.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Alan Knight
8 years ago (2012-12-21 22:22:37 UTC) #1
sethladd
https://codereview.chromium.org/11624031/diff/1/pkg/serialization/lib/serialization.dart File pkg/serialization/lib/serialization.dart (right): https://codereview.chromium.org/11624031/diff/1/pkg/serialization/lib/serialization.dart#newcode48 pkg/serialization/lib/serialization.dart:48: * de-serialize objects. This can be more work for ...
8 years ago (2012-12-22 00:06:24 UTC) #2
Kathy Walrath
lgtm, aside from the clarification Seth asked for
8 years ago (2012-12-22 00:08:07 UTC) #3
Alan Knight
https://codereview.chromium.org/11624031/diff/1/pkg/serialization/lib/serialization.dart File pkg/serialization/lib/serialization.dart (right): https://codereview.chromium.org/11624031/diff/1/pkg/serialization/lib/serialization.dart#newcode48 pkg/serialization/lib/serialization.dart:48: * de-serialize objects. This can be more work for ...
8 years ago (2012-12-22 00:31:21 UTC) #4
Kathy Walrath
8 years ago (2012-12-22 00:39:42 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698