Issue 11624011: Mirrors implemented via patches. 2nd try.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11624011: Mirrors implemented via patches. 2nd try. (Closed)

Created:
8 years ago by Johnni Winther

Modified:
8 years ago

Reviewers:
ahe, Mads Ager (google)

CC:
reviews_dartlang.org, Anders Johnsen, Mads Ager (google), turnidge

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mirrors implemented via patches. 2nd try. Committed: https://code.google.com/p/dart/source/detail?r=16317

Patch Set 1 : First attempt #

Patch Set 2 : Second attempt #

Total comments: 1

Patch Set 3 : Updated cf. comment. #

Patch Set 4 : Rebased #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -867 lines)			Patch
A	runtime/lib/mirrors_patch.dart	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	runtime/lib/mirrors_sources.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
D	sdk/lib/_internal/compiler/implementation/lib/mirrors.dart	View		1 chunk	+0 lines, -96 lines	0 comments	Download
A +	sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart	View		1 chunk	+14 lines, -18 lines	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View	1 2 3	1 chunk	+3 lines, -727 lines	0 comments	Download
A +	sdk/lib/mirrors/mirrors_impl.dart	View	1 2 3	3 chunks	+3 lines, -21 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors_sources.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years ago (2012-12-19 10:37:56 UTC) #5

LGTM!

https://codereview.chromium.org/11624011/diff/4001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/11624011/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:543: || libraryName ==
'dart:mirrors') {
Perhaps you shouldn't move this line.

Expand Messages | Collapse Messages