Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1162363004: Support Package Resolution Configuration files. (Closed)

Created:
5 years, 6 months ago by Harry Terkelsen
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org, sethladd, pquitslund
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : Fix tests #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : Fix tests #

Patch Set 9 : Skip another test #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -65 lines) Patch
M DEPS View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/compiler.dart View 4 chunks +14 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/apiimpl.dart View 1 2 3 4 5 6 7 8 9 14 chunks +91 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 2 3 4 5 6 7 8 9 8 chunks +19 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/analyze.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 2 3 4 5 6 7 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/bad_output_io_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 3 chunks +8 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/expect_annotations_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/import_mirrors_test.dart View 1 2 3 4 chunks +16 lines, -16 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Harry Terkelsen
5 years, 6 months ago (2015-06-02 21:43:59 UTC) #2
Harry Terkelsen
Some tests are failing because dart2js now depends on package_config, which depends on http, which ...
5 years, 6 months ago (2015-06-03 00:08:27 UTC) #3
Johnni Winther
LGTM but let's discuss dart:mirror dependency tomorrow over VC. https://codereview.chromium.org/1162363004/diff/40001/pkg/compiler/lib/src/apiimpl.dart File pkg/compiler/lib/src/apiimpl.dart (right): https://codereview.chromium.org/1162363004/diff/40001/pkg/compiler/lib/src/apiimpl.dart#newcode351 pkg/compiler/lib/src/apiimpl.dart:351: ...
5 years, 6 months ago (2015-06-03 11:36:39 UTC) #4
Harry Terkelsen
https://codereview.chromium.org/1162363004/diff/40001/pkg/compiler/lib/src/apiimpl.dart File pkg/compiler/lib/src/apiimpl.dart (right): https://codereview.chromium.org/1162363004/diff/40001/pkg/compiler/lib/src/apiimpl.dart#newcode351 pkg/compiler/lib/src/apiimpl.dart:351: Future setPackages(Uri uri) async { On 2015/06/03 11:36:39, Johnni ...
5 years, 6 months ago (2015-06-04 22:05:30 UTC) #5
Harry Terkelsen
Committed patchset #6 (id:100001) manually as 36c29d05bcc1dfe43a2f95698df5b41857f93221 (presubmit successful).
5 years, 6 months ago (2015-06-04 22:15:15 UTC) #6
Harry Terkelsen
Had to roll back because of broken tests. PTAL
5 years, 6 months ago (2015-06-08 22:16:55 UTC) #7
Johnni Winther
lgtm
5 years, 6 months ago (2015-06-09 07:47:43 UTC) #8
Harry Terkelsen
5 years, 6 months ago (2015-06-09 18:07:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #10 (id:180001) manually as
63681d5b59a26d00233ee582e8f9b9fa63c0bd80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698