Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 11623004: Fixes to eventhandler and HTTP (Closed)

Created:
8 years ago by Søren Gjesse
Modified:
8 years ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes to eventhandler and HTTP 1. Improve error handling in Windows event handler Whenever an error happens on an IO operation this generates an error event and the handle is marked as having has an error. The test http_shutdown_test have been fixed to check for error as well as succesful request when the server is closing the connection due to closing the output stream before the input have been read. The test have also been extended to have the client send more request data to get more errors. 2. Disable event handler events until re-enabled from Dart When an eventhandle event is posted to Dart this event is now disabled in the eventhandler until re-enabled from Dart. On Linux and Mac OS this was already the case as the file descriptor for which the event(s) was posted was removed from epoll/kqueue when events was posted. On Windows this is now changed so that after an event is posted it needs to be re-enabled from Dart code like on Linux and Mac OS. Changed the Dart event handler code to avoid posting disabling of the out handler as the C++ code is already doing this on all platforms. 3. Cancel HTTP parser when a connection is closing When a HTTP connection is closing and moved to the close queue there should be no more envents from the HTTP parser for whatever data is still buffered. R=ager@google.com BUG=7294 Committed: https://code.google.com/p/dart/source/detail?r=16252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -54 lines) Patch
M runtime/bin/eventhandler_win.h View 3 chunks +5 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_win.cc View 7 chunks +54 lines, -40 lines 0 comments Download
M runtime/bin/socket.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/io/socket_stream_impl.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/http_shutdown_test.dart View 4 chunks +13 lines, -4 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years ago (2012-12-18 09:14:33 UTC) #1
Mads Ager (google)
8 years ago (2012-12-18 11:48:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698