Fix setting breakpoint in non-finalized class

Fix setting breakpoint in non-finalized class.

This fixes issue 15870

Also added test case and verified manually that test case fails before this fix.

R=iposva@google.com, jacobr@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31449

[Jacob, 2014-01-03 01:47:18]

This fixes the dartium test failure as well.

[hausner, 2014-01-03 17:56:18]

Thank you.

[Ivan Posva, 2014-01-03 20:21:13]

LGTM -ip

https://codereview.chromium.org/116223006/diff/40001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/116223006/diff/40001/runtime/vm/debugger.cc#n...
runtime/vm/debugger.cc:1495: cls.EnsureIsFinalized(isolate_);
What happens if there is a compilation failure during the compilation? We should
probably drop the compilation failure on the floor and wait for some other code
to run into it again.

[Jacob, 2014-01-03 20:37:59]

lgtm

[hausner, 2014-01-03 20:50:36]

Committed patchset #2 manually as r31449 (presubmit successful).

[hausner, 2014-01-03 20:52:52]

Thank you.

https://codereview.chromium.org/116223006/diff/40001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/116223006/diff/40001/runtime/vm/debugger.cc#n...
runtime/vm/debugger.cc:1495: cls.EnsureIsFinalized(isolate_);
On 2014/01/03 20:21:13, Ivan Posva wrote:
> What happens if there is a compilation failure during the compilation? We
should
> probably drop the compilation failure on the floor and wait for some other
code
> to run into it again.

The compilation error gets dropped and the class remains unfinalized. It appears
to have no class members. When the program later references the class, it will
produce an appropriate compilation error.