associate @deprecated with enum element

associate @deprecated with enum element

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/1c1a87e820b50c9fd54d4e349681f19c12310bc5

[danrubel, 2015-06-04 22:51:21]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com, scheglov@google.com

[Brian Wilkerson, 2015-06-04 23:10:11]

LGTM

https://codereview.chromium.org/1162013007/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/1162013007/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/element_resolver.dart:206: @override
Re-insert the blank line between members? (Is this a formatter issue?)

https://codereview.chromium.org/1162013007/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/element_resolver.dart:2654: new
List<ElementAnnotationImpl>();
Why not "<ElementAnnotationImpl>[]"?

[scheglov, 2015-06-05 15:08:37]

https://codereview.chromium.org/1162013007/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/element_test.dart (right):

https://codereview.chromium.org/1162013007/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/element_test.dart:60: expect(elementA.isDeprecated,
isFalse);
This test is not an appropriate place to test isEnum or isDeprecated.
It is for computeNode().
I think we need to add a new test.

[Brian Wilkerson, 2015-06-05 15:14:34]

https://codereview.chromium.org/1162013007/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/element_test.dart (right):

https://codereview.chromium.org/1162013007/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/element_test.dart:60: expect(elementA.isDeprecated,
isFalse);
I disagree. Most of our test classes test the full behavior of a single class;
we write a FooTest class to contain the tests for the Foo class. This class is
ClassElementImplTest, so I would expect it to test all of the behavior of
ClassElementImpl. I think it's an historic accident that the only behavior of
the element classes that's being tested is computeNode and that it's fine to
extend these tests to cover more of the element model's behavior.

If you're suggesting that we change the way our tests are organized, then I
think an e-mail thread would be a better place to discuss it.

[danrubel, 2015-06-17 14:44:57]

Committed patchset #3 (id:40001) manually as
1c1a87e820b50c9fd54d4e349681f19c12310bc5 (presubmit successful).

[danrubel, 2015-06-17 15:06:32]

https://codereview.chromium.org/1162013007/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/1162013007/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/element_resolver.dart:2654: new
List<ElementAnnotationImpl>();
On 2015/06/04 23:10:11, Brian Wilkerson wrote:
> Why not "<ElementAnnotationImpl>[]"?

Done.