Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1161873007: Refactor outstdanding callbacks in invoker.dart. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 6 months ago
Reviewers:
Bob Nystrom, kevmoo
CC:
reviews_dartlang.org, kevmoo
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor outstdanding callbacks in invoker.dart. This also gives scheduled_test and similar systems a hook for tracking outstanding callbacks without having to reinvent the wheel. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/20413f4b0dea4c53880462ebb6b8681092072202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -10 lines) Patch
M lib/src/backend/invoker.dart View 2 chunks +25 lines, -9 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/backend/invoker_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nweiz
5 years, 6 months ago (2015-05-28 21:15:30 UTC) #2
kevmoo
Yes! LGTM
5 years, 6 months ago (2015-05-28 21:31:31 UTC) #4
nweiz
5 years, 6 months ago (2015-05-28 21:36:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
20413f4b0dea4c53880462ebb6b8681092072202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698