Issue 11617022: Add LICENSE if none exists, and skip .svn directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11617022: Add LICENSE if none exists, and skip .svn directories. (Closed)

Created:
8 years ago by dgrove

Modified:
8 years ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add LICENSE if none exists, and skip .svn directories. Committed: https://code.google.com/p/dart/source/detail?r=16281

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
	M	tools/publish_pkg.py	View	1 2 3	2 chunks	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm. If you don't mind, compiler_unsupported is still being rejected for 2 other reasons: * ...

8 years ago (2012-12-18 19:04:15 UTC) #2

dgrove

8 years ago (2012-12-18 19:09:47 UTC) #3

I took care of these, and uploaded a new compiler_unsupported.

On 2012/12/18 19:04:15, John Messerly wrote:
> lgtm.
> 
> If you don't mind, compiler_unsupported is still being rejected for 2 other
> reasons:
> 
> * Your pubspec.yaml must have an "author" or "authors" field.
> * Your pubspec.yaml is missing a "homepage" field.

Expand Messages | Collapse Messages