Issue 11614024: Fix closing of process stdin on Process.run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11614024: Fix closing of process stdin on Process.run. (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix closing of process stdin on Process.run. R=sgjesse@google.com BUG=dartbug/7473 Committed: https://code.google.com/p/dart/source/detail?r=16244

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/bin/process_patch.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

https://codereview.chromium.org/11614024/diff/1/runtime/bin/process_patch.dart File runtime/bin/process_patch.dart (right): https://codereview.chromium.org/11614024/diff/1/runtime/bin/process_patch.dart#newcode317 runtime/bin/process_patch.dart:317: p.stdin.close(); Oops.

8 years ago (2012-12-18 07:38:44 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages