Issue 11613007: Include super type in interface list for cycle detection (issue 4318).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11613007: Include super type in interface list for cycle detection (issue 4318). (Closed)

Created:
8 years ago by regis

Modified:
8 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Include super type in interface list for cycle detection (issue 4318). Report an error if a type appears in both extends clause and implements clause. Add language test. Close old pending issue 4905685. Committed: https://code.google.com/p/dart/source/detail?r=16237

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -121 lines)			Patch
M	runtime/vm/class_finalizer.h	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	5 chunks	+90 lines, -97 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	4 chunks	+13 lines, -20 lines	0 comments	Download
A	tests/language/class_cycle_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/11613007/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/11613007/diff/1/runtime/vm/class_finalizer.cc#newcode1253 runtime/vm/class_finalizer.cc:1253: void ClassFinalizer::ResolveInterfaces(const Class& cls, rename ResolveSuperTypesAndInterfaces

8 years ago (2012-12-18 00:06:11 UTC) #2

regis

8 years ago (2012-12-18 00:12:03 UTC) #3

Thanks!

https://codereview.chromium.org/11613007/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/11613007/diff/1/runtime/vm/class_finalizer.cc...
runtime/vm/class_finalizer.cc:1253: void ClassFinalizer::ResolveInterfaces(const
Class& cls,
On 2012/12/18 00:06:11, srdjan wrote:
> rename ResolveSuperTypesAndInterfaces

Renamed to ResolveSuperTypeAndInterfaces

Expand Messages | Collapse Messages