Issue 1161183004: Another tweak for displaying performance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1161183004: Another tweak for displaying performance. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Another tweak for displaying performance. 1. It is still interesting to see performance tags, even with the next task model. 2. Factor out "WorkOrder.moveNext" as a separate performance tag, something like "intertask" for new tasks. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1c1497ff9854f9eecc2c8ad5f51be0e5f19cea10

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -56 lines)			Patch
	M	pkg/analysis_server/lib/src/get_handler.dart	View		2 chunks	+45 lines, -35 lines	0 comments	Download
	M	pkg/analyzer/lib/src/task/driver.dart	View		2 chunks	+26 lines, -21 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 6 months ago (2015-06-05 16:19:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1c1497ff9854f9eecc2c8ad5f51be0e5f19cea10 (presubmit successful).