Issue 11610006: Revert revision 16240

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11610006: Revert revision 16240 (Closed)

Created:
8 years ago by ricow1

Modified:
8 years ago

Reviewers:
Anton Muhin, Mads Ager (google), blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert revision 16240 This is causing compilation errors on dartium. Anton/Peter: could you coordinate relanding this with the code removed from multivm bindings? Committed: https://code.google.com/p/dart/source/detail?r=16246

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+434 lines, -25 lines)			Patch
M	samples/swarm/swarm_ui_lib/touch/FxUtil.dart	View	1 chunk	+6 lines, -16 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	5 chunks	+208 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	5 chunks	+193 lines, -0 lines	0 comments	Download
M	sdk/lib/html/idl/dart/dart.idl	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	sdk/lib/html/scripts/htmlrenamer.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/html/css_test.dart	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

On 2012/12/18 08:54:05, Anton Muhin wrote: > Thanks a lot, Pete Oops, Rico, of course

8 years ago (2012-12-18 08:54:16 UTC) #4

blois

On 2012/12/18 08:54:16, Anton Muhin wrote: > On 2012/12/18 08:54:05, Anton Muhin wrote: > > ...

8 years ago (2012-12-18 16:19:19 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages